Skip to content

Sync Java core duplicate discriminator fix - #5381

Merged
Xiaofei Cao (XiaofeiCao) merged 6 commits into
Azure:release/august-2026from
XiaofeiCao:xiaofeicao-sync-core-pr-11824
Sep 9, 2026
Merged

Sync Java core duplicate discriminator fix#5381
Xiaofei Cao (XiaofeiCao) merged 6 commits into
Azure:release/august-2026from
XiaofeiCao:xiaofeicao-sync-core-pr-11824

Conversation

@XiaofeiCao

@XiaofeiCao Xiaofei Cao (XiaofeiCao) commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Testing

  • built the pinned Java generator with the Azure customization patch
  • ran generator-core tests (53 passed)

Upstream: microsoft/typespec#11824

@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:java Issues for @azure-tools/typespec-java emitter label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • @azure-tools/typespec-java
Show changes

@azure-tools/typespec-java - fix ✏️

Avoid duplicate inherited discriminator fields in generated Java models.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-java@5381

commit: 3621032

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📦 Package size report

✅ No notable package size changes compared to the base branch.

13 package(s) with no notable change
Package Packed (base → head) Δ Packed Unpacked (base → head) Δ Unpacked
@azure-tools/typespec-java 13.51 MB → 13.51 MB +154 B (+0.0%) 15.04 MB → 15.04 MB +815 B (+0.0%)
@azure-tools/azure-http-specs 146.62 KB → 146.62 KB 1.16 MB → 1.16 MB
@azure-tools/typespec-autorest 80.93 KB → 80.93 KB 395.06 KB → 395.06 KB
@azure-tools/typespec-autorest-canonical 7.42 KB → 7.42 KB 26.00 KB → 26.00 KB
@azure-tools/typespec-azure-core 129.43 KB → 129.43 KB 702.77 KB → 702.77 KB
@azure-tools/typespec-azure-portal-core 42.40 KB → 42.40 KB 192.91 KB → 192.91 KB
@azure-tools/typespec-azure-resource-manager 171.16 KB → 171.16 KB 1.04 MB → 1.04 MB
@azure-tools/typespec-azure-rulesets 5.16 KB → 5.16 KB 32.09 KB → 32.09 KB
@azure-tools/typespec-client-generator-core 226.23 KB → 226.23 KB 1.22 MB → 1.22 MB
@azure-tools/typespec-go 247.01 KB → 247.01 KB 1.25 MB → 1.25 MB
@azure-tools/typespec-metadata 15.91 KB → 15.91 KB 62.26 KB → 62.26 KB
@azure-tools/typespec-python 46.21 KB → 46.21 KB 180.83 KB → 180.83 KB
@azure-tools/typespec-ts 527.17 KB → 527.17 KB 2.54 MB → 2.54 MB

Packed = gzipped .tgz published to npm. Unpacked = total extracted size. 🆕 added, 🗑️ removed. Packages from the core/ submodule are not included.
🔴 grew · 🟢 shrank — only changes of at least 512 B and 0.5% are marked.

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

You can try these changes here

🛝 Playground 🌐 Website

@XiaofeiCao
Xiaofei Cao (XiaofeiCao) changed the base branch from main to release/august-2026 September 4, 2026 09:08
Pin the Java emitter to microsoft/typespec#11824 and sync its inherited discriminator regression case.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
Advance the pinned core commit to the latest microsoft/typespec#11824 head and resync its discriminator regression fixtures.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
Advance to the latest microsoft/typespec#11824 commit and sync its XML discriminator regression fixture.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
Advance to the latest microsoft/typespec#11824 commit and sync the restored propagated discriminator regression fixture.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
Advance to the latest microsoft/typespec#11824 head and sync its focused inherited discriminator tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
Advance the Java emitter pin to the merged microsoft/typespec#11824 main commit and sync the latest core tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e11a1a40-39fd-4e62-a567-584fde94178c
@XiaofeiCao
Xiaofei Cao (XiaofeiCao) merged commit eec1f8d into Azure:release/august-2026 Sep 9, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:java Issues for @azure-tools/typespec-java emitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants